Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock observations model #28

Closed
wants to merge 4 commits into from
Closed

Mock observations model #28

wants to merge 4 commits into from

Conversation

pazbardanl
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

MockObservations model generates mock observations for testing and demo purposes

pazbardanl
pazbardanl commented Jan 22, 2024
View reviewed changes
src/lib/mock-observations/README.md
@@ -0,0 +1,81 @@
# Mock Observations Model
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR should be opened on official models repo

pazbardanl
pazbardanl commented Jan 22, 2024
View reviewed changes
src/lib/mock-observations/README.md
@@ -0,0 +1,81 @@
# Mock Observations Model
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README should reflect the model is in official models repo

pazbardanl
pazbardanl commented Jan 22, 2024
View reviewed changes
src/lib/mock-observations/interfaces/index.ts
/**
* initialise the generator with the given name and config.
*/
initialise(name: String, config: {[key: string]: any}): void;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check with Asim if we can replace this with a plain ctor

@pazbardanl pazbardanl marked this pull request as draft January 23, 2024 09:12
@pazbardanl pazbardanl closed this Jan 29, 2024
@pazbardanl
Copy link
Contributor Author

closed PR since mock-observations model is going into the official models repo

@jmcook1186 jmcook1186 deleted the mock-observations-model branch March 20, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narekhovhannisyan narekhovhannisyan Awaiting requested review from narekhovhannisyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pazbardanl @narekhovhannisyan